SSL Labs ScoreSecurityHeaders.io ScoreHSTS Preloaded

Log in to participate

There is no cost to join RicheyWeb, and membership is a requirement to submit bug reports and participate in the support forums.

BUG: IE Conditionals causing js files not to work?!

More
3 weeks 3 days ago - 3 weeks 3 days ago #3932 by jjnxpct
We use version 3.5.9

When we add a js file and leave 'IE Conditionals' the plugin does add text around the script tag, like this:

<!--[if ]><script src="/templates/intranet/js/main.js" type="text/javascript"></script><![endif]-->

This causes the script not to load.

This means after updating to the latest version all our sites are missing our added js files!! This is quit a big issue for us.

Hope this can be fixed soon.

Or maybe we are missing something. In that case we also need some assistance.
Last edit: 3 weeks 3 days ago by jjnxpct.

Please Log in or Create an account to join the conversation.

More
3 weeks 3 days ago #3933 by jjnxpct
I commented out this line in the headtag.php file (188):

//if(isset($rule->conditional)) { $rule->options = $rule->conditional; }

This helps for now, but we now need to do this on all sits using the plugin.

Hope you can fix this and release a new version. Thanks.

Please Log in or Create an account to join the conversation.

More
3 weeks 2 days ago #3946 by michael
Is there a space, perhaps, in the conditionals field? I can cause that to happen on my test server by putting a space into the IE conditionals field.

I'm not saying it's acceptable, and I do have some code to fix it - but I thought it might be important to know if that's the cause.

Please Log in or Create an account to join the conversation.

More
3 weeks 2 days ago #3947 by jjnxpct
Hi Michael, I don't believe there are or were any spaces. It happened on existing sites, on all js files at the same time. I think after on the the latest updates. But not sure which one.

Please Log in or Create an account to join the conversation.

More
3 weeks 2 days ago #3952 by michael
OK.... I can only make it happen if I add a space in the field, so I'm going with my current fix, which is to trim the value and check it for length before applying the conditional markup.

Please Log in or Create an account to join the conversation.

More
3 weeks 1 day ago #3956 by michael
3.5.10 is out - still working on that update XML issue.

Please Log in or Create an account to join the conversation.

  • Not Allowed: to create new topic.
  • Not Allowed: to reply.
  • Not Allowed: to edit your message.
Powered by Kunena Forum